One critique from a senior dev in Portland fixed my code reviews

A senior dev on my team told me my review comments were mostly "drive-by nitpicks" after we did a retro last quarter. He pointed out I focused on style stuff like variable names instead of asking about edge cases or test coverage. I started rewriting my comments as questions, like "what happens if the API returns null here?” instead of just stating what to change. That shift got me way more buy-in from juniors, and my own code improved because I think about intent before syntax. Anybody else get feedback that forced a total rethink of how they communicate at work?

1 comments

1 Comment

the_lucas21d ago

Swap your question comments for intent questions too. Ask "what are you trying to solve here?" before you ever mention syntax. That forces you to actually read their code instead of scanning for spaces and names. Also, keep a list of the same 5 questions you ask every time: null handling, failure paths, test cases, edge inputs, and how it fits the bigger feature. Repeating those gets boring but it builds a baseline, and juniors start pre-answering them before you even ask.